lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Corrected comments and a function check_meshing_chords divided in tw


From: dak
Subject: Re: Corrected comments and a function check_meshing_chords divided in two. (issue 5975054)
Date: Sat, 14 Apr 2012 17:01:36 +0000

On 2012/04/14 15:21:26, Milimetr88 wrote:
>
I didn't expected so long reply. The whole patch is about adding some
comments to the code, splitting *one* function in two

But you split the function in two at an arbitrary point in the middle,
package all of its local variables from the first half into
a class structure, and then pass this class structure into the second
half of the function.

Where is the point?  Is either half of the function used for some other
purpose as well?  _Could_ it even be used for some other purpose?  What
is the purpose of creating this function border and parameter-passing
API?

http://codereview.appspot.com/5975054/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]