Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

[graham]

LGTM


http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh
File flower/include/direction.hh (right):

http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh#newcode78
flower/include/direction.hh:78: #define DOWN_and_UP(d) \
I see that our code uses both versions, and I fully support this patch
making a simple substitution for these macros.

After it's accepted, it might be nice to investigate this further: do we
ever depend on the order of DOWN_and_UP, and if not, could we
standardize on UP_and_DOWN (or vice versa).

It might also be nice to standardize on either (d) or (dir); I support
the latter.  However, this is again something which should happen after
this patch is pushed.

http://codereview.appspot.com/6109046/