Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

[Łukasz Czerwiński]

On 25 April 2012 17:06, David Kastrup <address@hidden> wrote:

Łukasz Czerwiński <address@hidden> writes:

> I have never ever get an email from Google Code. I have just checked
> that triple. That's the reason for ignoring your comments. I'm sorry
> that my new patch made you run your tests twice to give me the same
> list of errors...
>  
> Do you run tests for each patch uploaded to Rietveld?

I won't any more.  It is high time somebody else pitches in.  Neither my
computing power nor my personality make me suitable for that job.

I see... Unfortunately I won't be any help in that.

 

> Ok, thank you. But compiling and running regtests took approx. 2.5
> hours. It's very long...

Half of that is setting the baseline.  It should be somewhat less: I
think it took about 2 hours on my previous laptop (10 years old).  When
it broke down, another senior developer sent me the money for a model
that is 5 years old (Intel Core 2 Duo at 1.8GHz).  A full comparison
including baseline is now something short of 40 minutes (if there are
several patches in the queue, only a single baseline gets made).  Pretty
much every other developer has more powerful hardware available: some
even has been explicitly bought for LilyPond work, and the fully
automated tests for pushing to master, quite more expensive than the
patch testing, are run on such a system.

I run that on a virtual machine which makes it slower and it uses one core instead of two, so it's slower again... I will think of using native Ubuntu, but I really like working using Windows 7, so that will be hard choice :)

Should I take in account diffs that got printed after make check?

They look like this:

(...)

+++ out/voice-5-midi.ly 2012-04-25 16:24:51.779884744 +0200

@@ -10,14 +10,8 @@

     \consists "Completion_rest_engraver"

   }

 }

-\midi {

-  \context {

-    \Score

-    midiChannelMapping = #'instrument

-  }

-}

 

-% included from ./out-www/voice-5.header

+% included from ./out/voice-5.header

 \header {

 texidoc="midi2ly still produces output for a staff with five voices.  However, in such cases, most probably the the correct \voiceOne, \voiceX... mapping is lost."

 options=""

@@ -43,39 +37,71 @@ trackA = <<

 >>

 

 

-trackBchannelA = \relative c {

-  \voiceOne

+trackBchannelA = {

+  

+  \set Staff.instrumentName = "trackB:voiceA"

+  

+}

+

+trackBchannelB = {

+  \skip 1 

+  | % 2

+  

+  \set Staff.instrumentName = "trackB:voiceE"

+  

+}

+

+trackBchannelC = {

   

-  \set Staff.instrumentName = ":1"

+  \set Staff.instrumentName = "trackB:voiceD"

+  

+}

+

+trackBchannelD = {

+  

+  \set Staff.instrumentName = "trackB:voiceC"

+  

+}

+

+trackBchannelE = {

+  

+  \set Staff.instrumentName = "trackB:voiceB"

+  

+}

+

+trackBchannelF = \relative c {

+  \voiceOne

   <c''' a >2 b 

   | % 2

   

 }

 

-trackBchannelB = \relative c {

+trackBchannelG = \relative c {

   \voiceThree

   c''4. d8 e4 f 

   | % 2

   

 }

 

-trackBchannelC = \relative c {

+trackBchannelH = \relative c {

   \voiceFour

   d'1 

   | % 2

   

 }

 

-trackBchannelD = \relative c {

+trackBchannelI = \relative c {

   \voiceTwo

   c'4 c2 c4 

   | % 2

   

 }

 

-trackBchannelE = \relative c {

-  s1 d1

+trackBchannelJ = \relative c {

+  r1 

   | % 2

+  d 

+  | % 3

   

 }

 

@@ -85,6 +111,11 @@ trackB = <<

   \context Voice = voiceC \trackBchannelC

   \context Voice = voiceD \trackBchannelD

   \context Voice = voiceE \trackBchannelE

+  \context Voice = voiceF \trackBchannelF

+  \context Voice = voiceG \trackBchannelG

+  \context Voice = voiceH \trackBchannelH

+  \context Voice = voiceI \trackBchannelI

+  \context Voice = voiceJ \trackBchannelJ

 >>

 

Łukasz