Re: hideNotes should hide also TabNoteHead (issue 2480). (issue 6105049)

[fedelogy]

Reviewers: Graham Percival, Keith, Neil Puttock, dak,

Message:
On 2012/04/23 12:20:36, Neil Puttock wrote:
> Nevertheless, the voicing should be fixed
> even if it means adding explicit \voiceOne commands at appropriate
places.  It
> looks bad with both voices stem-down.


voiceOne and voiceTwo were already present.
The stem direction was messed up by the grace at the beginning of the
piece. I removed it and now stems look good.


Description:
hideNotes should hide also TabNoteHead (issue 2480).
Tablature example updated accordingly.

Please review this at http://codereview.appspot.com/6105049/

Affected files:
  M Documentation/ly-examples/tab-example.ly
  M ly/property-init.ly


Index: Documentation/ly-examples/tab-example.ly
diff --git a/Documentation/ly-examples/tab-example.ly  
b/Documentation/ly-examples/tab-example.ly
index  
c2be0d7b5961ff03e165a341b835ec153ca26c4e..a6822231f77f301875aaf2b76ef55bf44d1cab17  
100644
--- a/Documentation/ly-examples/tab-example.ly
+++ b/Documentation/ly-examples/tab-example.ly
@@ -14,17 +14,6 @@
          (- (ly:pitch-alteration right-pitch) (ly:pitch-alteration  
left-pitch))
          0 )))

-% Hide fret number: useful to draw slide into/from a casual point of
-% the fretboard.
-hideFretNumber = {
-  \once \override TabNoteHead #'transparent = ##t
-  \once \override TabNoteHead #'whiteout = ##f
-  \once \override NoteHead #'transparent = ##t
-  \once \override Stem #'transparent = ##t
-  \once \override Flag #'transparent = ##t
-  \once \override NoteHead #'no-ledgers = ##t
-}
-
 \paper {
   indent= #0
   line-width= #180
@@ -36,7 +25,7 @@ upper= \relative c' {
   \set Staff.midiInstrument = #"acoustic guitar (steel)"
   \set fingeringOrientations = #'(left)

-  \partial 4. \acciaccatura c16 \glissando cis8 e4
+  \partial 4. cis8 e4
   < cis-1 g'-3 >2 s8 \grace a16 ( \glissando < b-2 >8\3 ) < d-1 > ( b )
   < e-3 >\2 ( <d-1> b ) \grace < ais-2 >16 ( \glissando a8 g ) s4.
   s4. < d'\3 g\2 >8 < gis,\4  d'\3 fis\2 >2\arpeggio ~
@@ -49,7 +38,7 @@ lower= \relative c {
   \partial 4. s4.
   s4 e,4 s2
   s2 s8 < e'-3 >4. ~
-  e4 \hideFretNumber \grace { b8 \glissando s4 } < e-2 >4\5 e,2 ~
+  e4 \hideNotes \grace { b8 \glissando s4 } \unHideNotes < e-2 >4\5 e,2 ~
   e2 < e'\6\harmonic >
 }

Index: ly/property-init.ly
diff --git a/ly/property-init.ly b/ly/property-init.ly
index  
cec33d9a42530e46a9a26f712c4cc08506924cd6..c0b352254ad0f195cb20d99465180ca5c706440a  
100644
--- a/ly/property-init.ly
+++ b/ly/property-init.ly
@@ -248,6 +248,7 @@ hideNotes = {
   \override Beam #'transparent = ##t
   \override Accidental #'transparent = ##t
   \override Rest #'transparent = ##t
+  \override TabNoteHead #'transparent = ##t
 }
 unHideNotes = {
   \revert Accidental #'transparent
@@ -258,6 +259,7 @@ unHideNotes = {
   \revert NoteHead #'no-ledgers
   \revert Dots #'transparent
   \revert Rest #'transparent
+  \revert TabNoteHead #'transparent
 }