[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adds tick mark to scripts (issue 6568055)
From: |
lemzwerg |
Subject: |
Re: Adds tick mark to scripts (issue 6568055) |
Date: |
Thu, 27 Sep 2012 06:49:48 +0000 |
LGTM.
http://codereview.appspot.com/6568055/diff/1/mf/feta-scripts.mf
File mf/feta-scripts.mf (right):
http://codereview.appspot.com/6568055/diff/1/mf/feta-scripts.mf#newcode1774
mf/feta-scripts.mf:1774: set_char_box (0, 1.7 staff_space# + epsilon,
I suggest to use a tightest bounding box. At least I don't see any
reason to not do so. The question is whether it makes sense to give
this glyph a depth (this is, to make the glyph go below the baseline),
but this is only a matter of taste.
http://codereview.appspot.com/6568055/
- Adds tick mark to scripts (issue 6568055), PhilEHolmes, 2012/09/26
- Re: Adds tick mark to scripts (issue 6568055), dak, 2012/09/26
- Re: Adds tick mark to scripts (issue 6568055), PhilEHolmes, 2012/09/26
- Re: Adds tick mark to scripts (issue 6568055),
lemzwerg <=
- Re: Adds tick mark to scripts (issue 6568055), PhilEHolmes, 2012/09/27
- Re: Adds tick mark to scripts (issue 6568055), janek . lilypond, 2012/09/27
- Re: Adds tick mark to scripts (issue 6568055), Phil Holmes, 2012/09/27
- Re: Adds tick mark to scripts (issue 6568055), Janek Warchoł, 2012/09/27
- Re: Adds tick mark to scripts (issue 6568055), Phil Holmes, 2012/09/28
- Re: Adds tick mark to scripts (issue 6568055), Janek Warchoł, 2012/09/28
- Re: Adds tick mark to scripts (issue 6568055), Phil Holmes, 2012/09/28
- Re: Adds tick mark to scripts (issue 6568055), James, 2012/09/28
- Re: Adds tick mark to scripts (issue 6568055), Phil Holmes, 2012/09/28
- Re: Adds tick mark to scripts (issue 6568055), Janek Warchoł, 2012/09/29