lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Create \temporary for doing overrides without pop-first set (issue 6


From: dak
Subject: Re: Create \temporary for doing overrides without pop-first set (issue 6687044)
Date: Mon, 15 Oct 2012 14:28:44 +0000


http://codereview.appspot.com/6687044/diff/4001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/6687044/diff/4001/ly/music-functions-init.ly#newcode1250
ly/music-functions-init.ly:1250: @emph{corresponding} reverts in a
stack-neutral manner.  An
On 2012/10/15 06:30:12, janek wrote:
Could you write explicitely both here and in the commit message that
"as of
2.17.5, \override is a pop+push"?

Had i not participated in previous discussion, i would have no idea
why some
overrides could be pop-first and what that could actually mean to the
music.

_All_ \override are "pop-first".  This is not the place to document it.
I might try to rephrase this, but something like "as of 2.17.5,
\override is a pop+push" has no place whatsoever in the documentation
string of a function.

The documentation string is not the place for hand-waving suggestions of
possible changes.  It is supposed to document the current state, period.

http://codereview.appspot.com/6687044/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]