lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Grow heap aggressively during music interpretation (issue 561390043


From: Han-Wen Nienhuys
Subject: Re: Grow heap aggressively during music interpretation (issue 561390043 by address@hidden)
Date: Mon, 3 Feb 2020 10:20:58 +0100

On Mon, Feb 3, 2020 at 9:35 AM Han-Wen Nienhuys <address@hidden> wrote:
>
> On Sun, Feb 2, 2020 at 11:47 PM <address@hidden> wrote:
> >
> > On 02/02/2020 22:33, Han-Wen Nienhuys wrote:
> > > For me, juggling 15 different outstanding code reviews at the same
> > > time is the bane of the current development process.
> >
> > what do you suggest?
>
> I think we should move to a git-based code review tool; Github, Gitlab
> or Gerrit.  Gerrit is probably the closest to the current workflow.
>
> Then, you could push an entire branch with several commits for review.
>
> The state of the change could be administered within the code review
> itself, so we don't need to keep tools in sync with each other.

In Gerrit, you can define your own labels (with permission who can
vote on them). See for example,

  https://review.gerrithub.io/c/hanwen/lilypond/+/483638

This has a label for "passes make doc" and "regtest visual
inspection". One can drive CI systems by querying for the result, eg.

  https://review.gerrithub.io/q/project:hanwen/lilypond++label:Passes-Make-Doc

(with the label) or

 https://review.gerrithub.io/q/project:hanwen/lilypond++-label:Passes-Make-Doc

(without the label).

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen



reply via email to

[Prev in Thread] Current Thread [Next in Thread]