Re: Grow heap aggressively during music interpretation (issue 561390043 by address@hidden)

[Han-Wen Nienhuys]

On Mon, Feb 3, 2020 at 9:35 AM Han-Wen Nienhuys <address@hidden> wrote:
> > On 02/02/2020 22:33, Han-Wen Nienhuys wrote:
> > > For me, juggling 15 different outstanding code reviews at the same
> > > time is the bane of the current development process.
> >
> > what do you suggest?
>
> I think we should move to a git-based code review tool; Github, Gitlab
> or Gerrit.  Gerrit is probably the closest to the current workflow.

For Github, you can define labels and checks to apply to pull-requests,

  
https://help.github.com/en/github/managing-your-work-on-github/applying-labels-to-issues-and-pull-requests

and you can define rules that require checks to pass before merging the PR.

  https://developer.github.com/v3/repos/statuses/

Gitlab has support for CI within the gitlab product itself,

 https://docs.gitlab.com/ee/ci/introduction/index.html#basic-cicd-workflow


Gitlab/Github have the advantage over Gerrit that they include bug
tracker integration (ie. you can easily track which commits fix which
bugs and vice versa).

Gerrit offers a more refined reviewing experience.

Gitlab and Gerrit are open source, with the latter probably being
easier to deploy (as it does less things.)

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen