Re: Persian music package

[Thomas Morley]

Am So., 1. Aug. 2021 um 09:58 Uhr schrieb Kees van den Doel <kvdoel@gmail.com>:
>
> OK, so I'll stick with my own convert-ly files as I'm on the stabgle version.
>
> Problem now seems to be that the positioning tweak in persian.ly such as 
> "persianStringsXExtents" is no longer working correctly with my file. 
> Strangely the YExtents and Offset work fine, eg if I make Y-Extent large the 
> beams move out of the way.
>
> persianStringsXExtents = #`(
>        (-3/10 . (0 . 1) )
>        (1/5   . (0 . 1.8))     %<--- this should control how "wide" the koron 
> is but it has no effect
>        (0     . (0 . 1))
>        (1/2   . (0 . 1))
>        (2/5   . (0 . 1))
>        (-1/2  . (0 . 1))
>        (-3/5  . (0 . 1))
>        (-1/10 . (0 . 1))
>        (-1    . (0 . 1.8))
>        ( 1    . (0 . 1.3))
> )
>     \override Accidental.X-extent =  #(lambda (grob)
>          (cdr (assoc (ly:grob-property grob 'alteration)
>                   persianStringsXExtents )))
>
> On Sat, Jul 31, 2021 at 11:21 PM Jean Abou Samra <jean@abou-samra.fr> wrote:
>>
>> Le 01/08/2021 à 08:06, Kees van den Doel a écrit :
>> > convert-ly from LP v2.22.1 also didn;t add the "alteration-" here.
>> > Windows 10 system.
>>
>> (Please keep the list posted, so everyone can reply
>> and benefit from the answers.)
>>
>> convert-ly from 2.22.1 is expected not to do this,
>> because the renaming was done in LilyPond 2.23.3.
>>
>> Best,
>> Jean

I'd simply drop your overrides for Accidental.Y-extent and Accidental.X-extent.
Let the skylines do their job as already proposed by Jean.

Furthermore I'd replace the override for Accidental.extra-offset by:
    \override Accidental.Y-offset =
      #(lambda (grob)
          (cdr
            (assoc-get
              (ly:grob-property grob 'alteration)
              persianStringsOffsets)))
Though, why do you use pairs in persianStringsOffsets? Iiuc, you only
use the cdr of each pair.

Cheers,
  Harm