Re: device stuff - cvs

[Jan-Henrik Haukeland]

Christian Hopp <address@hidden> writes:

> On Wed, 11 Jun 2003, Jan-Henrik Haukeland wrote:
> 
> > Please make *usage* a noise keyword so it's possible to say:
> >
> > IF MEM(ORY) usage <operator> ..
> > IF CPU usage <operator> ..
> >
> 
> It is already.... you see that we should really think about tidying
> up!
 
Okay, good. Suggestions for cleaning up?

> > > > Anyway, I think it should be possible to deprecate the current
> > > > resource syntax for this release already because this particularry
> > > > change is slight. Simply add the same deprecation code to the parser
> > > > like we have done with for instance autostart:
> > > >
> > > > autostart       : AUTOSTART {
> > > >                     YERROR("Warning: 'autostart' is deprecated - "
> > > >                            "use the 'mode' statement instead");
> > > >                   }
> > > >                 ;
> > >
> > > That's not a "warning"... warnings are usually non fatal.  You should say
> > > error!
> >
> > Errors should be reserved for stopping monit after parsing. I think
> > that using a statement without any effect is a warning because monit
> > may and should run. But using the word 'deprecated' is probably
> > unfortunate since the user may think that the statement has effect but
> > that he is recomended to use the new statement version. This is how
> > "deprecated" is used in e.g. Java, i.e. using a deprecated
> > method/class/whatever still works. In our case we should use the word
> > 'defunct' instead so the user knows that the statement has ceased to
> > exist. What do you think?
> 
> Let say obsolete!
> 
> The syntax is not available anymore! That means monit wont parse it
> successfully, anymore.  Thus, it is an error... IHMO.

Okay, 'obsolete' is fine. Beside I see that in the lates checkin that
this is already flagged as an error (via YERROR), this is also okay by
me. Let's leave it like that and please "obsolete" my previous mail on
the subject :)

-- 
Jan-Henrik Haukeland