Re: [Monotone-devel] strptime not in MinGW time.h

[Stephen Leake]

Zack Weinberg <address@hidden> writes:

> On Sat, May 22, 2010 at 4:09 AM, Stephen Leake
> <address@hidden> wrote:
>> Currently, 'status' checks to see if date_fmt (either from the option or
>> from hook_get_date_format_spec) is valid, in the sense that
>> date_t::as_formatted_localtime and date_t::from_formatted_localtime
>> succeed when using it.
>>
>> On Win32, this check will always fail, because strptime is not
>> implemented.
>>
>> So get_log_message_interactively should do the same check to decide
>> whether to allow editing the commit date.
>>
>> That way, even on Unix, if the user provides a date_fmt that strptime
>> doesn't like, commit won't fail.
>
> We need to make it visually obvious in the editor when editing the
> date won't have any effect, if we do this.

It turned out to be better than that. If date_fmt is not valid, just use
the default date format (and issue a warning); you can then edit the date.

Now tested on Win32 and Debian; all tests are passing.

-- 
-- Stephe