Re: [Monotone-devel] strptime not in MinGW time.h

[Thomas Keller]

Am 22.05.10 17:11, schrieb Stephen Leake:
> Stephen Leake <address@hidden> writes:
> 
>> Currently, 'status' checks to see if date_fmt (either from the option or
>> from hook_get_date_format_spec) is valid, in the sense that
>> date_t::as_formatted_localtime and date_t::from_formatted_localtime
>> succeed when using it.
>>
>> So get_log_message_interactively should do the same check to decide
>> whether to allow editing the commit date.
> 
> This is now implemented in a8147b11ee2d598835a4e1cec0e9782e4388e679.
> 
> All tests are passing on Win32.

Not quite for me though on Mac OS X - the test commit_default_editor fails.

The last two test there read

  check(mtn("--branch", "testbranch", "commit",
            "--date-format", "foo"), 0, false, true)
  check(qgrep("date format 'foo' cannot be used for "..
              "commit; using default instead", "stderr"))

but instead of warning about the unusable format, it aborts completely
for me (probably nearby cmd_ws_commit.cc:1543).

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature