nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [Request] allow deleting a marked region without affect


From: Brand Huntsman
Subject: Re: [Nano-devel] [Request] allow deleting a marked region without affecting the cutbuffer
Date: Wed, 17 Oct 2018 15:36:51 -0600

First patch fixes the memory leak and previous issues, both patches add 
documentation.


> > Ya, ZAP was used for undo, and I realize that name looks like
> > alphabet soup. But it makes some sense if you know what BSP and DEL
> > are in that context, because it enables zap for those keys.  
> 
> True, but if there are still plans to eventually allow M-Del to zap
> marked text, regardless of the -Z option, mentioning Bsp and Del in
> the description might be confusing.

The description should mention the keys it alters. I don't see the confusion, 
but would it be better if it said "unmodified backspace and delete keys"?


> Also, I'm wondering: how do you generate your git patches?  I'm
> currently using git 2.19.1, and when I try applying your patches via
> git am, I just get "Patch format detection failed."  If I manually
> delete the ">" from the beginning of the first "From" line, then it
> can detect them, but it's unusual.

The file in my sent folder doesn't have the > at the top of each patch,
but it is present at
http://lists.gnu.org/archive/html/nano-devel/2018-10/msg00065.html

If these new patches have the >, could someone try attaching a test patch and 
see if it gets altered?

...
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=0001-add-bindable-zap-function.patch

From 8b912be5f5e33f51cf46674b9adcfbbe55c0a3ac Mon Sep 17 00:00:00 2001
...
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename=0002-zap-selection-with-Bsp-Del-keys-when-enabled-with-za.patch

From c5b3a99c3bfd0e372c074ea06a2f42ccc67d5301 Mon Sep 17 00:00:00 2001
...

Attachment: 0001-add-bindable-zap-function.patch
Description: Text Data

Attachment: 0002-zap-selection-with-Bsp-Del-keys-when-enabled.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]