[Octave-bug-tracker] [bug #59277] [octave-forge](io) xls2oct is slow when a spreadsheet contains many text cells

[Philip Nienhuis]

Follow-up Comment #22, bug #59277 (project octave):

Running through the collected bug report spreadsheets I found another reason
for the for loop you stripped away, apart from comment #17: sharedStrings.xml
can have nodes with (empty) contents like 
<si><t/></si>
(while full nodes may look like <si><t>Some text</t></si> )
which gives differently sized empty cells in array "strings" (L.142). These
are skipped by the regexp on L.145 and as a consequence nasty indexing errors
are provoked further down.
I've found a simple fix, hopefully it doesn't eliminate the performance gains
:-)

Along the way also found & fixed another, unrelated bug. Always handy to have
such a collection :-)

BTW may I credit you in the io package NEWS file? I found your email address
(I have some priviliges here) and I think I can guess your name.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59277>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/