[Octave-bug-tracker] [bug #59277] [octave-forge](io) xls2oct is slow when a spreadsheet contains many text cells

[Dennis]

Follow-up Comment #27, bug #59277 (project octave):

> If you want you can benchmark if you get still better performance than the
version you made up in comment #24.

With the version I made in comment #24, my test sheet yields the following:

Elapsed time is 39.2871 seconds.
   #         Function Attr     Time (s)   Time (%)        Calls
---------------------------------------------------------------
  23           regexp            18.893      48.49           50
  32         cell2mat             8.556      21.96        20060
  13 __OCT_xlsx2oct__             2.719       6.98           10
  24          cellfun             1.719       4.41       100350
  26              cat             1.554       3.99        20070


With your final version posted in comment #26, it yields:

Elapsed time is 37.3439 seconds.
   #         Function Attr     Time (s)   Time (%)        Calls
---------------------------------------------------------------
  23           regexp            18.376      49.58           50
  32         cell2mat             8.250      22.26        20050
  13 __OCT_xlsx2oct__             2.645       7.14           10
  26              cat             1.509       4.07        20060
  46       str2double             1.490       4.02           20


So very similar performance (I must say, the duration varies a bit, the first
run with you latest code took 46s).

Then my real life application (three runs each):
- code from comment #24: 10.5 sec, 10.6 sec, 10.4 sec.
- Code from comment #27: 11.4 sec, 9.5 sec, 10.2 sec

Conclusion: the final code seems to perform fine. Many thanks for your quick
and helpful response.

Just for my understanding (I know the details of releasing package updates),
will you release a version 2.6.3 of the io package?

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59277>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/