octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #59277] [octave-forge](io) xls2oct is slow whe


From: Philip Nienhuis
Subject: [Octave-bug-tracker] [bug #59277] [octave-forge](io) xls2oct is slow when a spreadsheet contains many text cells
Date: Sun, 25 Oct 2020 15:32:48 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0

Follow-up Comment #25, bug #59277 (project octave):

> So, replacing lines 204 and 205 as follows may speed up things further:
> idx.num = vi.row;
> idx.alph = vi.alph; 
Good catch!

A little further down, 
* that 2nd assignment idx.alph = vi.alph seems a bit useless, vi.alph isn't
referenced afterwards;
and
* vi.col turns out to be identical to idx.alph, so even idx.alph isn't
referenced anymore.

This is original code that AFAICR I haven't ever touched except for column and
row limits. I need to look better to not screw up things, the program flow
isn't exactly straightforward.
But some more optimization is due, absolutely.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59277>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]