|
From: | Markus Mützel |
Subject: | [Octave-bug-tracker] [bug #59706] Avoid "canonicalize_file_name" on Windows |
Date: | Tue, 22 Dec 2020 03:43:51 -0500 (EST) |
User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36 Edg/87.0.664.66 |
Follow-up Comment #22, bug #59706 (project octave): I pushed a change with Rik's suggestions to stable here: https://hg.savannah.gnu.org/hgweb/octave/rev/45abff4199d8 I don't think gnulib uses its `canonicalize_file_name` replacement for its `stat` replacement on Windows. It would be much more performant if they used Windows API calls instead for their `stat` replacement (at least I hope they do). If this is the case, the slow `canonicalize_file_name` replacement might be eliminated from this code path completely after the recent changes. That doesn't mean that there won't be more places where we could replace `canonicalize_file_name` by something more efficient (on Windows!) in our own code. It might be that a new `normalize_file_name` will be a good replacement in some occasions. But that decision must be made on a per case basis. _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?59706> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |