[patch #5511] Clean up variable formats

[John Darrington]

Update of patch #5511 (project pspp):

             Assigned to:                     jmd => blp                    

    _______________________________________________________

Follow-up Comment #1:

I can't see any major issues.  Some minor ones:

* Will the // comments in operations.def be OK with a C89 compiler?
* There are some msg strings in format.c which should probably use ngettext
instead of gettext, to ensure that plural forms can be translated. Eg:
"allows at most %d decimals."
* fmt_date_template: There is  an analagous function in
src/ui/gui/var-type-dialog.c called dollar_format_template.  Would it make
sense to put these in the same file ?
* In src/data/data-in.c, why do the FMT_CC? values assert NOT_REACHED() ?  Is
it not feasible to input a custom currency value ?


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5511>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/