[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5511] Clean up variable formats

From: John Darrington
Subject: [patch #5511] Clean up variable formats
Date: Fri, 03 Nov 2006 03:34:25 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20060926 Debian/1.7.8-1sarge7.3.1

Update of patch #5511 (project pspp):

             Assigned to:                     jmd => blp                    


Follow-up Comment #1:

I can't see any major issues.  Some minor ones:

* Will the // comments in operations.def be OK with a C89 compiler?
* There are some msg strings in format.c which should probably use ngettext
instead of gettext, to ensure that plural forms can be translated. Eg:
"allows at most %d decimals."
* fmt_date_template: There is  an analagous function in
src/ui/gui/var-type-dialog.c called dollar_format_template.  Would it make
sense to put these in the same file ?
* In src/data/data-in.c, why do the FMT_CC? values assert NOT_REACHED() ?  Is
it not feasible to input a custom currency value ?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]