pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #5511] Clean up variable formats


From: John Darrington
Subject: Re: [patch #5511] Clean up variable formats
Date: Sat, 4 Nov 2006 06:41:11 +0800
User-agent: Mutt/1.5.4i

On Fri, Nov 03, 2006 at 06:32:42AM -0800, Ben Pfaff wrote:
     
     > If not, it ought to be locale dependent.  
     
     I actually don't think so: the SPSS manuals don't say anything
     about adaptation to language here, and so I assume that these are
     not locale dependent.
     
     > On the other hand, if debug is the primary motivation for this
     > function, then maybe it ought to be seperate from
     > dollar_format_template which is for user interaction.
     
     I think they have a different purpose: fmt_date_template is for
     internal use in parsing and output, dollar_format_template is
     useful for user interaction.

OK.  I agree.  The syntax should not be dependent upon locale (except
perhaps that identifiers can come from different character sets).  In
that case, fmt_date_template and dollar_format_template should be
distinct functions.   However it might still be a good idea to put
them both in the same place (and rename them so that their purpose is
clear).

J'

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.


Attachment: pgp5rDzATd9S3.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]