pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #5511] Clean up variable formats


From: John Darrington
Subject: Re: [patch #5511] Clean up variable formats
Date: Tue, 7 Nov 2006 18:18:35 +0800
User-agent: Mutt/1.5.4i

On Mon, Nov 06, 2006 at 09:06:26AM -0800, Ben Pfaff wrote:

     > OK.  I agree.  The syntax should not be dependent upon locale (except
     > perhaps that identifiers can come from different character sets).  In
     > that case, fmt_date_template and dollar_format_template should be
     > distinct functions.   However it might still be a good idea to put
     > them both in the same place (and rename them so that their purpose is
     > clear).
     
     OK.  I'll move it and rename it, and possibly rename
     fmt_date_template as well, to clarify everything.
     
OK.  Thanks.  The "." and "," in this function needs to be substituted
by the appropriate character (from SET /DECIMAL). 

     If I also generalize dollar_format_template to cover any format,
     as part of moving and renaming it, will you find it to be more
     useful?  I am willing to do so, but only if it is worthwhile.

I can't imagine any place where it would be used.  So it's probably
not worthwhile doing at this stage.  Thanks.


J'

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.


Attachment: pgpumD5F6BedU.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]