[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5562] line-buffer / getl_ reorganisation

From: Ben Pfaff
Subject: [patch #5562] line-buffer / getl_ reorganisation
Date: Wed, 29 Nov 2006 05:37:32 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/20061024 Iceweasel/2.0 (Debian-2.0+dfsg-1)

Update of patch #5562 (project pspp):

                  Status:   Ready For Test/Review => Works For Me           
             Assigned to:                     blp => jmd                    


Follow-up Comment #3:

I'm pretty happy with this.  Nit-picking follows:

In prompt.[ch], could the functions be renamed to put "prompt" at the
beginning?  e.g. get_prompt_style -> prompt_get_style and so on.  This
would make it clear at a glance that they come from a module named

I think that the function source is only used in DO REPEAT.  I wonder
whether it should be merged in with it.  It seems like the
function_source is a really thin wrapper around getl_interface now; it
was less apparently "thin" before, because it *was* the exposed
interface.  If you don't like merging it, could the source file be
named something less generic?  Maybe "function-source.c"?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]