[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PSPP & PSPPIRE running as native windows applications.
From: |
John Darrington |
Subject: |
Re: PSPP & PSPPIRE running as native windows applications. |
Date: |
Thu, 8 Feb 2007 21:52:19 +0900 |
User-agent: |
Mutt/1.5.9i |
On Wed, Feb 07, 2007 at 09:49:25PM -0800, Ben Pfaff wrote:
> The bad snprintf might also cause segfaults if it fails to terminate
> the string with '\0'.
>
> Indeed. In order to mitigate this problem, it might be a good idea in
> rank.q to increase the length of func_abb (rank.q:700) by 1, and
> initialise it with zeros.
I'd rather seek other solutions (for example, improving gnulib or
fixing mingw) before modifying correct PSPP code, not least
because I'm liable to forget why code has been changed away from
what seems obviously correct.
As a general rule, I agree. However, if other solutions prove to be
ellusive, or inappropriate, then sometimes a quick but "incorrect"
solution is justified. If that turns out to be the case, then the
code should be prominently commented to explain why the "incorrect"
code has been inserted.
We should probably drop this entirely from configure.ac:
AM_CONDITIONAL(unix, test x"$host_os" != x"msdos" )
AM_CONDITIONAL(msdos, test x"$host_os" = x"msdos" )
Definitely. (I have an embarrasing feeling that I was responsible for that).
I propose this patch:
--- debugger.c.~1.2.~ 2006-12-16 13:15:30.000000000 -0800
+++ debugger.c 2007-02-07 21:37:01.000000000 -0800
@@ -18,6 +18,9 @@
I concurr.
J'
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.
signature.asc
Description: Digital signature
- PSPP & PSPPIRE running as native windows applications., John McCabe-Dansted, 2007/02/06
- Re: PSPP & PSPPIRE running as native windows applications., John McCabe-Dansted, 2007/02/12
- Re: PSPP & PSPPIRE running as native windows applications., Ben Pfaff, 2007/02/13
- libintl dependency, John Darrington, 2007/02/14
- Re: libintl dependency, Ben Pfaff, 2007/02/16
- Re: PSPP & PSPPIRE running as native windows applications., Ben Pfaff, 2007/02/09
Re: PSPP & PSPPIRE running as native windows applications., Ben Pfaff, 2007/02/06