[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PSPP on windows: backtraces.
From: |
Ben Pfaff |
Subject: |
Re: PSPP on windows: backtraces. |
Date: |
Thu, 22 Feb 2007 06:24:33 -0800 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
John Darrington <address@hidden> writes:
> Looking at the code again, I think the line
> fwrite (rec, len, 1, w->file);
>
> is not strictly correct. It ought to read
>
> fwrite (rec, sizeof (*rec), len, w->file);
*shrug*
No objection to the change, but it can't make a difference either
way.
> I'm also wondering if, on mingw32, putc ('\n', w->file) ought not to
> be followed by putc ('\r', w->file).
I'm pretty sure that we open the output file in text mode, so
that the underlying OS should translate '\n' to whatever is the
correct line terminator for the OS. (And I think that \r
generally precedes \n.)
--
Ben Pfaff
address@hidden
http://benpfaff.org