[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 9/9] escc: fix STATUS_SYNC bit in R_STATUS register
From: |
Mark Cave-Ayland |
Subject: |
[PATCH v2 9/9] escc: fix STATUS_SYNC bit in R_STATUS register |
Date: |
Thu, 2 Sep 2021 11:22:05 +0100 |
After an SDLC "Enter hunt" command has been sent the STATUS_SYNC bit should
remain
high until the flag byte has been detected. Whilst the ESCC device doesn't yet
implement SDLC mode, without this change the active low STATUS_SYNC is
constantly
asserted causing the MacOS OpenTransport extension to hang on startup as it
thinks
it is constantly receiving LocalTalk responses during its initial negotiation
phase.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/char/escc.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/char/escc.c b/hw/char/escc.c
index 29fcdcb625..b566758d62 100644
--- a/hw/char/escc.c
+++ b/hw/char/escc.c
@@ -94,6 +94,7 @@
#define W_IVEC 2
#define W_RXCTRL 3
#define RXCTRL_RXEN 0x01
+#define RXCTRL_HUNT 0x10
#define W_TXCTRL1 4
#define TXCTRL1_PAREN 0x01
#define TXCTRL1_PAREV 0x02
@@ -582,7 +583,13 @@ static void escc_mem_write(void *opaque, hwaddr addr,
break;
}
break;
- case W_INTR ... W_RXCTRL:
+ case W_RXCTRL:
+ s->wregs[s->reg] = val;
+ if (val & RXCTRL_HUNT) {
+ s->rregs[R_STATUS] |= STATUS_SYNC;
+ }
+ break;
+ case W_INTR ... W_IVEC:
case W_SYNC1 ... W_TXBUF:
case W_MISC1 ... W_CLOCK:
case W_MISC2 ... W_EXTINT:
--
2.20.1
- [PATCH v2 4/9] escc: introduce escc_hard_reset_chn() for hardware reset, (continued)
[PATCH v2 5/9] escc: implement soft reset as described in the datasheet, Mark Cave-Ayland, 2021/09/02
[PATCH v2 6/9] escc: implement hard reset as described in the datasheet, Mark Cave-Ayland, 2021/09/02
[PATCH v2 7/9] escc: remove register changes from escc_reset_chn(), Mark Cave-Ayland, 2021/09/02
[PATCH v2 8/9] escc: re-use escc_reset_chn() for hard and soft reset, Mark Cave-Ayland, 2021/09/02
[PATCH v2 9/9] escc: fix STATUS_SYNC bit in R_STATUS register,
Mark Cave-Ayland <=