[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 082/117] target/arm: Move sve check into gen_gvec_fn_ppp
From: |
Peter Maydell |
Subject: |
[PULL 082/117] target/arm: Move sve check into gen_gvec_fn_ppp |
Date: |
Mon, 30 May 2022 17:06:33 +0100 |
From: Richard Henderson <richard.henderson@linaro.org>
Combined with the check already present in gen_mov_p,
we can simplify some special cases in trans_AND_pppp
and trans_BIC_pppp.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220527181907.189259-80-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target/arm/translate-sve.c | 30 ++++++++++++------------------
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 364e419f3eb..f33bc9d480b 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -370,13 +370,16 @@ static void do_dupi_z(DisasContext *s, int rd, uint64_t
word)
}
/* Invoke a vector expander on three Pregs. */
-static void gen_gvec_fn_ppp(DisasContext *s, GVecGen3Fn *gvec_fn,
+static bool gen_gvec_fn_ppp(DisasContext *s, GVecGen3Fn *gvec_fn,
int rd, int rn, int rm)
{
- unsigned psz = pred_gvec_reg_size(s);
- gvec_fn(MO_64, pred_full_reg_offset(s, rd),
- pred_full_reg_offset(s, rn),
- pred_full_reg_offset(s, rm), psz, psz);
+ if (sve_access_check(s)) {
+ unsigned psz = pred_gvec_reg_size(s);
+ gvec_fn(MO_64, pred_full_reg_offset(s, rd),
+ pred_full_reg_offset(s, rn),
+ pred_full_reg_offset(s, rm), psz, psz);
+ }
+ return true;
}
/* Invoke a vector move on two Pregs. */
@@ -1317,19 +1320,13 @@ static bool trans_AND_pppp(DisasContext *s, arg_rprr_s
*a)
};
if (!a->s) {
- if (!sve_access_check(s)) {
- return true;
- }
if (a->rn == a->rm) {
if (a->pg == a->rn) {
- do_mov_p(s, a->rd, a->rn);
- } else {
- gen_gvec_fn_ppp(s, tcg_gen_gvec_and, a->rd, a->rn, a->pg);
+ return do_mov_p(s, a->rd, a->rn);
}
- return true;
+ return gen_gvec_fn_ppp(s, tcg_gen_gvec_and, a->rd, a->rn, a->pg);
} else if (a->pg == a->rn || a->pg == a->rm) {
- gen_gvec_fn_ppp(s, tcg_gen_gvec_and, a->rd, a->rn, a->rm);
- return true;
+ return gen_gvec_fn_ppp(s, tcg_gen_gvec_and, a->rd, a->rn, a->rm);
}
}
return do_pppp_flags(s, a, &op);
@@ -1358,10 +1355,7 @@ static bool trans_BIC_pppp(DisasContext *s, arg_rprr_s
*a)
};
if (!a->s && a->pg == a->rn) {
- if (sve_access_check(s)) {
- gen_gvec_fn_ppp(s, tcg_gen_gvec_andc, a->rd, a->rn, a->rm);
- }
- return true;
+ return gen_gvec_fn_ppp(s, tcg_gen_gvec_andc, a->rd, a->rn, a->rm);
}
return do_pppp_flags(s, a, &op);
}
--
2.25.1
- [PULL 046/117] target/arm: Use TRANS_FEAT for do_vpz_ool, (continued)
- [PULL 046/117] target/arm: Use TRANS_FEAT for do_vpz_ool, Peter Maydell, 2022/05/30
- [PULL 052/117] target/arm: Use TRANS_FEAT for do_index, Peter Maydell, 2022/05/30
- [PULL 060/117] target/arm: Move sve zip high_ofs into simd_data, Peter Maydell, 2022/05/30
- [PULL 061/117] target/arm: Use gen_gvec_ool_arg_zzz for do_zip, do_zip_q, Peter Maydell, 2022/05/30
- [PULL 070/117] target/arm: Use TRANS_FEAT for do_sve2_ppzz_flags, Peter Maydell, 2022/05/30
- [PULL 073/117] target/arm: Use TRANS_FEAT for MUL_zzi, Peter Maydell, 2022/05/30
- [PULL 074/117] target/arm: Reject dup_i w/ shifted byte early, Peter Maydell, 2022/05/30
- [PULL 094/117] target/arm: Use TRANS_FEAT for FRECPE, FRSQRTE, Peter Maydell, 2022/05/30
- [PULL 095/117] target/arm: Expand frint_fns for MO_8, Peter Maydell, 2022/05/30
- [PULL 096/117] target/arm: Rename do_zpz_ptr to gen_gvec_ool_fpst_arg_zpz, Peter Maydell, 2022/05/30
- [PULL 082/117] target/arm: Move sve check into gen_gvec_fn_ppp,
Peter Maydell <=
- [PULL 084/117] target/arm: Use TRANS_FEAT for SEL_zpzz, Peter Maydell, 2022/05/30
- [PULL 086/117] target/arm: Use TRANS_FEAT for FMLA, Peter Maydell, 2022/05/30
- [PULL 092/117] target/arm: Move null function and sve check into do_reduce, Peter Maydell, 2022/05/30
- [PULL 064/117] target/arm: Use TRANS_FEAT for do_clast_fp, Peter Maydell, 2022/05/30
- [PULL 075/117] target/arm: Reject add/sub w/ shifted byte early, Peter Maydell, 2022/05/30
- [PULL 080/117] target/arm: Introduce gen_gvec_{ptr,fpst}_zzzz, Peter Maydell, 2022/05/30
- [PULL 027/117] target/arm: Use TRANS_FEAT for gen_gvec_ool_arg_zpzi, Peter Maydell, 2022/05/30
- [PULL 079/117] target/arm: Use TRANS_FEAT for do_zzi_ool, Peter Maydell, 2022/05/30
- [PULL 087/117] target/arm: Use TRANS_FEAT for BFMLA, Peter Maydell, 2022/05/30
- [PULL 051/117] target/arm: Move sve check into do_index, Peter Maydell, 2022/05/30