Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

[Richard Henderson]

On 3/20/23 07:33, Alex Bennée wrote:
> Claudio Fontana <cfontana@suse.de> writes:
>
> > On 3/20/23 14:32, Alex Bennée wrote:
> > > Claudio Fontana <cfontana@suse.de> writes:
> > >
> > > > How is this conditional on CONFIG_TCG? To me it looks like this breaks 
> > > > !CONFIG_TCG.
> > > > Careful, the meson.build in accel/tcg/meson.build is always recursed.
> > >
> > > Surely it shouldn't be in accel/tcg then?
> >
> >
> > Hi Alex,
> >
> > maybe we did not understand each other.
> >
> > What I mean is that accel/tcg/meson.build is not conditionally read, it is 
> > _always_ read.
> >
> > Therefore TCG-specific code needs to be conditionally included using
> > the CONFIG_TCG.
>
> Ahh I see now, right I can fix that up next revision if there is
> interest in this approach.

Yes, that seems fine.  With either when: or subdir_done(),

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~