[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu |
|
Date: |
Mon, 20 Mar 2023 14:33:52 +0000 |
|
User-agent: |
mu4e 1.9.22; emacs 29.0.60 |
Claudio Fontana <cfontana@suse.de> writes:
> On 3/20/23 14:32, Alex Bennée wrote:
>>
>> Claudio Fontana <cfontana@suse.de> writes:
>>
>>> How is this conditional on CONFIG_TCG? To me it looks like this breaks
>>> !CONFIG_TCG.
>>> Careful, the meson.build in accel/tcg/meson.build is always recursed.
>>
>> Surely it shouldn't be in accel/tcg then?
>
>
> Hi Alex,
>
> maybe we did not understand each other.
>
> What I mean is that accel/tcg/meson.build is not conditionally read, it is
> _always_ read.
>
> Therefore TCG-specific code needs to be conditionally included using
> the CONFIG_TCG.
Ahh I see now, right I can fix that up next revision if there is
interest in this approach.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- Re: [PATCH 06/10] includes: move irq definitions out of cpu-all.h, (continued)
Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu, Alessandro Di Federico, 2023/03/21
[PATCH 07/10] accel/tcg: use QEMU_IOTHREAD_LOCK_GUARD to cover the exit, Alex Bennée, 2023/03/20