[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/10] includes: move irq definitions out of cpu-all.h
From: |
Alessandro Di Federico |
Subject: |
Re: [PATCH 06/10] includes: move irq definitions out of cpu-all.h |
Date: |
Tue, 21 Mar 2023 17:06:52 +0100 |
On Mon, 20 Mar 2023 10:10:31 +0000
Alex Bennée <alex.bennee@linaro.org> wrote:
> +#define CPU_INTERRUPT_HARD 0x0002
Out of curiosity, do we have a policy when to use `const` globals as
opposed to `#define`?
In theory, if a constant is never used in any preprocessor directive,
we could turn it into a global `const`.
It'd be nice to reduce the pre-processor usage, sometimes I end up
debugging build issues by taking a compiler's command line and adding
`-E`, and the less you use the pre-processor, the better.
Reviewed-by: Alessandro Di Federico <ale@rev.ng>
--
Alessandro Di Federico
rev.ng Labs