Re: [PATCH v7 02/10] target/ppc: Readability improvements in exception handlers

[Peter Maydell]

On Tue, 27 Feb 2024 at 15:10, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> Improve readability by shortening some long comments, removing
> comments that state the obvious and dropping some empty lines so they
> don't distract when reading the code.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> Acked-by: Nicholas Piggin <npiggin@gmail.com>


> -    /*
> -     * new interrupt handler msr preserves existing ME unless
> -     * explicitly overridden.
> -     */
> +    /* new interrupt handler msr preserves ME unless explicitly overriden */

Minor typo introduced here: should be "overridden".

>      new_msr = env->msr & (((target_ulong)1 << MSR_ME));

> @@ -575,16 +558,10 @@ static void powerpc_excp_6xx(PowerPCCPU *cpu, int excp)
>      /* new srr1 value excluding must-be-zero bits */
>      msr = env->msr & ~0x783f0000ULL;
>
> -    /*
> -     * new interrupt handler msr preserves existing ME unless
> -     * explicitly overridden
> -     */
> +    /* new interrupt handler msr preserves ME unless explicitly overriden */

Ditto, and similarly for other instances later in the patch.

thanks
-- PMM