Re: 52-factored-install.patch

[Akim Demaille]

Tom Tromey <address@hidden> writes:

> >>>>> "Akim" == akim  <address@hidden> writes:
> 
> Akim> My bad, I forgot to remove `dir' from the _DATA var.
> 
> Oops, I missed that too.
> 
> Akim> mybindir = $(bindir)/my
> Akim> mybin_DATA = doto
> 
> User defined variables are handled by name.
> I agree that this case is handled correctly with the current cvs.

OK, what I was not understanding was that rules where exclusive, and
based _only_ on the variables names, never on their value, nor on the
primary.

So it is my (today's :) understanding that I did wrong to have some
primaries independent from the dir name, right?  I mean:

~/src/am % egrep '^[^?]*install-(exec|data)-am.*:' *.am           nostromo 9:54
libs.am:.PHONY install-exec-am: address@hidden@LIBRARIES
ltlib.am:.PHONY install-exec-am: address@hidden@LTLIBRARIES
progs.am:.PHONY install-exec-am: address@hidden@PROGRAMS
python.am:.PHONY install-exec-am: address@hidden@PYTHON
scripts.am:.PHONY install-exec-am: address@hidden@SCRIPTS

are wrong, they should be like:

~/src/am % egrep '^.*[?].*install-(exec|data)-am.*:' *.am         nostromo 9:55
data.am:?EXEC?.PHONY install-exec-am: address@hidden@DATA
data.am:?!EXEC?.PHONY install-data-am: address@hidden@DATA
header.am:?EXEC?.PHONY install-exec-am: address@hidden@HEADERS
header.am:?!EXEC?.PHONY install-data-am: address@hidden@HEADERS
java.am:?EXEC?.PHONY install-exec-am: address@hidden@JAVA
java.am:?!EXEC?.PHONY install-data-am: address@hidden@JAVA
lisp.am:?EXEC?.PHONY install-exec-am: address@hidden@LISP
lisp.am:?!EXEC?.PHONY install-data-am: address@hidden@LISP
mans-vars.am:?INSTALL-MAN?install-data-am: install-man
texinfos.am:?!EXEC??INSTALL-INFO?install-data-am: install-info-am

(Hm, Pavel, I think this is the bug you reported :)

> Directory variables like sbindir which are defined by autoconf
> and the GNU standards are handled different.
> For instance sbindir is architeture-specific.
> So sbin_DATA must be installed by install-exec.
> 
> I've updated instdata2.test to check this.

But both CVS and 1.4 refuse sbin_DATA :(

am/tests/testSubDir % /usr/bin/automake -a                        nostromo 9:57
automake: Makefile.am: required file `./NEWS' not found
automake: Makefile.am: required file `./README' not found
automake: Makefile.am: required file `./AUTHORS' not found
automake: Makefile.am: required file `./ChangeLog' not found
Makefile.am:30: invalid variable `sbin_DATA'
am/tests/testSubDir % am                                         nostromo Err 1
automake: .am: required file `./NEWS' not found
automake: .am: required file `./README' not found
automake: .am: required file `./AUTHORS' not found
automake: .am: required file `./ChangeLog' not found
.am:30: invalid variable `sbin_DATA'