[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: extensions for emacsclient (CVS version)

From: Andreas Büsching
Subject: Re: extensions for emacsclient (CVS version)
Date: Wed, 10 Sep 2003 11:00:36 +0200
User-agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux)


Miles Bader <address@hidden> wrote:

> Andreas Büsching <address@hidden> writes:
>> -    sprintf (server.sun_path, "/tmp/emacs%d-%s/server", (int) geteuid (), 
>> system_name);
>> +    sprintf (server.sun_path, "%s", socket_name);
>> +    sprintf (server.sun_path, "/tmp/emacs%d-%s/server", (int) geteuid (), 
>> system_name);
> Hmmm, no bounds checking when writing into server.sun_path (the old code
> didn't either, but the constructed path is probably less likely to
> overflow).

If this is the only problem that is simple to fix! So we will replace
'sprintf(' with 'snprintf( sizeof server.sun_path, '. Is that what you


Hard work never killed anyone, but why give it a chance?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]