[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: extensions for emacsclient (CVS version)

From: Andreas Büsching
Subject: Re: extensions for emacsclient (CVS version)
Date: Wed, 10 Sep 2003 17:02:16 +0200
User-agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux)

"Stefan Monnier" <address@hidden> wrote:

> [ Please pass the -b option to diff for patches that are ment to be read
>   by humans. ]
>> +  else
>> +    {
>> +      while ((str = fgets (string, BUFSIZ, stdin)))
>> +    {
>> +      fprintf (out, "%s ", quote_file_name (str));
>> +    }
> Have you tested it to see if it works with a large multiline
> (and with long lines) stdin ?
> I think the space after %s might pose problems (if the input line
> is long and is cut in the middle of a symbol for example).
> I suggest to use just "%s" instead.

D'oh! I just tested it with a short expression, so you are right. I
will fix this.

> Other than that, it looks fine to me.  In order to be able to install
> this change in Emacs-CVS, we need to make sure you have signed the relevant
> paperwork (ideally an assignment of copyright covering all your changes to
> Emacs, IIRC you want to ask address@hidden to get the relevant form).

I guess there is no easier way to contribute to the emacs project?


"We're back to the times when men were men and wrote their own device 
     -- Linus Torvalds

reply via email to

[Prev in Thread] Current Thread [Next in Thread]