[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: extensions for emacsclient (CVS version)

From: Andreas Büsching
Subject: Re: extensions for emacsclient (CVS version)
Date: Wed, 10 Sep 2003 12:56:18 +0200
User-agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux)


Miles Bader <address@hidden> wrote:

> Andreas Büsching <address@hidden> writes:
>> > Hmmm, no bounds checking when writing into server.sun_path (the old code
>> > didn't either, but the constructed path is probably less likely to
>> > overflow).
>> If this is the only problem that is simple to fix! So we will replace
>> 'sprintf(' with 'snprintf( sizeof server.sun_path, '. Is that what you
>> mean?
> Well, it would probably be better to print an error message in the case
> of a user-specified socket name.  The size of sun_path is fairly small,
> actually, so an error is not all that unlikely.
> Also I'm not sure whether you're allowed to use snprintf, since it's not
> entirely portable, which emacs tries to be (I don't know if emacs
> contains its own version of snprintf for this purpose or not).

Okay, I understand, we _would_ need to find good and emacs like method
to handle this potential problem, but what I would like to know first is,
if this patch has any chance to get into CVS.


BREAKFAST.COM halted... cereal port not responding!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]