[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: extensions for emacsclient (CVS version)

From: Miles Bader
Subject: Re: extensions for emacsclient (CVS version)
Date: 10 Sep 2003 18:30:02 +0900

Andreas Büsching <address@hidden> writes:
> > Hmmm, no bounds checking when writing into server.sun_path (the old code
> > didn't either, but the constructed path is probably less likely to
> > overflow).
> If this is the only problem that is simple to fix! So we will replace
> 'sprintf(' with 'snprintf( sizeof server.sun_path, '. Is that what you
> mean?

Well, it would probably be better to print an error message in the case
of a user-specified socket name.  The size of sun_path is fairly small,
actually, so an error is not all that unlikely.

Also I'm not sure whether you're allowed to use snprintf, since it's not
entirely portable, which emacs tries to be (I don't know if emacs
contains its own version of snprintf for this purpose or not).

A zen-buddhist walked into a pizza shop and
said, "Make me one with everything."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]