Re: locate-with-filter

[Richard Stallman]

I think we can effectively eliminate help-follow.  It is not used for
following any of the links that are explicitly presented in the doc
string.

So I propose this change:


*** help-mode.el        07 Feb 2006 18:16:11 -0500      1.43
--- help-mode.el        17 Mar 2006 16:30:23 -0500      
*************** Commands:
*** 233,242 ****
    "Label to use by `help-make-xrefs' for the go-back reference.")
  
  (defconst help-xref-symbol-regexp
!   (purecopy (concat "\\(\\<\\(\\(variable\\|option\\)\\|"
!                   "\\(function\\|command\\)\\|"
!                   "\\(face\\)\\|"
!                   "\\(symbol\\)\\|"
                    "\\(source \\(?:code \\)?\\(?:of\\|for\\)\\)\\)"
                    "[ \t\n]+\\)?"
                    ;; Note starting with word-syntax character:
--- 233,242 ----
    "Label to use by `help-make-xrefs' for the go-back reference.")
  
  (defconst help-xref-symbol-regexp
!   (purecopy (concat "\\(\\<\\(\\(variable\\|option\\)\\|"  ; Link to var
!                   "\\(function\\|command\\)\\|"          ; Link to function
!                   "\\(face\\)\\|"                        ; Link to face
!                   "\\(symbol\\|program\\)\\|"            ; Don't link
                    "\\(source \\(?:code \\)?\\(?:of\\|for\\)\\)\\)"
                    "[ \t\n]+\\)?"
                    ;; Note starting with word-syntax character:
*************** help buffer."
*** 584,598 ****
  
  ;; Navigation/hyperlinking with xrefs
  
- (defun help-follow-mouse (click)
-   "Follow the cross-reference that you CLICK on."
-   (interactive "e")
-   (let* ((start (event-start click))
-        (window (car start))
-        (pos (car (cdr start))))
-     (with-current-buffer (window-buffer window)
-       (help-follow pos))))
- 
  (defun help-xref-go-back (buffer)
    "From BUFFER, go back to previous help buffer text using `help-xref-stack'."
    (let (item position method args)
--- 584,589 ----
*************** a proper [back] button."
*** 627,637 ****
--- 618,637 ----
    (let ((help-xref-following t))
      (apply function args)))
  
+ ;; The doc string is meant to explain what buttons do.
+ (defun help-follow-mouse (click)
+   "Follow the cross-reference that you CLICK on."
+   (interactive "e")
+   (error "No cross-reference here"))
+ 
+ ;; The doc string is meant to explain what buttons do.
  (defun help-follow (&optional pos)
    "Follow cross-reference at POS, defaulting to point.
  
  For the cross-reference format, see `help-make-xrefs'."
    (interactive "d")
+   (error "No cross-reference here"))
+ 
    (unless pos
      (setq pos (point)))
    (unless (push-button pos)