emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el fro


From: Stefan Monnier
Subject: Re: [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el from previous change
Date: Tue, 01 Oct 2019 11:08:31 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Hi Lars,

> --- a/lisp/emacs-lisp/bytecomp.el
> +++ b/lisp/emacs-lisp/bytecomp.el
> @@ -124,7 +124,7 @@
>  (require 'backquote)
>  (require 'macroexp)
>  (require 'cconv)
> -(eval-when-compile (require 'compile))
> +(require 'compile)

This is a bad change.

It brings in many more packages, and every additional package brought
in reduces the quality of our warnings (e.g. if any of the packages
(transitively) loaded load cl-lib, then we fail to signal when
a package uses cl-lib functionality without requiring cl-lib).

We should try and find some other solution.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]