Re: [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el from previous change

[Sven Joachim]

On 2019-10-01 11:08 -0400, Stefan Monnier wrote:

> Hi Lars,
>
>> --- a/lisp/emacs-lisp/bytecomp.el
>> +++ b/lisp/emacs-lisp/bytecomp.el
>> @@ -124,7 +124,7 @@
>>  (require 'backquote)
>>  (require 'macroexp)
>>  (require 'cconv)
>> -(eval-when-compile (require 'compile))
>> +(require 'compile)
>
> This is a bad change.
>
> It brings in many more packages, and every additional package brought
> in reduces the quality of our warnings (e.g. if any of the packages
> (transitively) loaded load cl-lib, then we fail to signal when
> a package uses cl-lib functionality without requiring cl-lib).

Indeed, this is bug #30635, mentioned in the comments you had written
just around Lars' changes:

,----
| ;; Refrain from using cl-lib at run-time here, since it otherwise prevents
| ;; us from emitting warnings when compiling files which use cl-lib without
| ;; requiring it! (bug#30635)
`----

> We should try and find some other solution.

Cheers,
       Sven