Re: [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el from previous change

[Stefan Monnier]

> I'm not quite sure I followed the last bit -- if something transitively
> required cl-lib, then there's no point for the "top" file to require
> cl-lib, surely?  Or is this a style issue.

If a file (transitively) required by bytecomp.el requires cl-lib,
then when compiling *another* file any missing (require 'cl-lib) in that
other file won't be noticed.

> (defvar emacs-lisp-compilation-mode-map
>   (let ((map (make-sparse-keymap)))
>     (set-keymap-parent map compilation-minor-mode-map)
>     (define-key map "g" 'emacs-lisp-compilation-recompile)
>     map))

Do we need this set-keymap-parent?  define-derived-mode should do it for
us (when the mode is called).


        Stefan