[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el fro

From: Lars Ingebrigtsen
Subject: Re: [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el from previous change
Date: Thu, 03 Oct 2019 17:18:51 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> I'm not quite sure I followed the last bit -- if something transitively
>> required cl-lib, then there's no point for the "top" file to require
>> cl-lib, surely?  Or is this a style issue.
> If a file (transitively) required by bytecomp.el requires cl-lib,
> then when compiling *another* file any missing (require 'cl-lib) in that
> other file won't be noticed.

Oh, this is just special for bytecomp.el; I get it.

>> (defvar emacs-lisp-compilation-mode-map
>>   (let ((map (make-sparse-keymap)))
>>     (set-keymap-parent map compilation-minor-mode-map)
>>     (define-key map "g" 'emacs-lisp-compilation-recompile)
>>     map))
> Do we need this set-keymap-parent?  define-derived-mode should do it for
> us (when the mode is called).

I didn't know that.  I've now made the change (and reverted the
`require'), and this do indeed work as they should.

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]