[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tab bar tabs landed on master

From: Eli Zaretskii
Subject: Re: Tab bar tabs landed on master
Date: Wed, 09 Oct 2019 13:51:57 +0300

> Date: Mon, 07 Oct 2019 22:23:55 +0300
> From: Eli Zaretskii <address@hidden>
> Cc: address@hidden, address@hidden
> > I prepared everything needed to test on a GPM-capable console,
> > so now I'm ready to help you in testing your patch.
> Thanks, I will send a patch soon, probably tomorrow.

(For some value of "tomorrow".  Sorry for the delay.)

The patch is below, I hope I didn't goof.  Let me know if there are
problems this causes.

It is possible that we will need to force reset of up_modifier bit
from the event modifiers inside tty_handle_tab_bar_click, I'm not
sure.  If you get error messages when clicking on the tab bar saying
something like "<tab-bar> <up-current-tab> is undefined", this is the

diff --git a/src/term.c b/src/term.c
index 6420105..b60484e 100644
--- a/src/term.c
+++ b/src/term.c
@@ -2568,6 +2568,14 @@ handle_one_term_event (struct tty_display_info *tty, 
Gpm_Event *event,
   else {
     f->mouse_moved = 0;
     term_mouse_click (&ie, event, f);
+    if (tty_handle_tab_bar_click (f, event->x, event->y,
+                                 (ie.modifiers & down_modifier) != 0, &ie))
+      {
+       /* tty_handle_tab_bar_click stores 2 events in the event
+          queue, so we are done here.  */
+       count += 2;
+       return count;
+      }

reply via email to

[Prev in Thread] Current Thread [Next in Thread]