[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: vertical fido-mode

From: Ergus
Subject: Re: vertical fido-mode
Date: Thu, 11 Jun 2020 15:03:41 +0200
User-agent: NeoMutt/20180716

Hi Omar!

Good to know that you agree with the needed changes as I proposed
them. Are you willing to implement them? If so, do you have a copyright

I am available to help you with anything you need (I am not a good
lisper any way). But I am really interested into see this functionality
in vanilla for fido-mode.


On Wed, Jun 10, 2020 at 07:55:09PM -0500, Omar Antol�n Camarena wrote:
Hi! I'm the author of icomplete-vertical. I'd be very happy to see the 
icomplete-vertical functionality included in Emacs, and Ergus is completely 

But as I see the code in icomplete-vertical-mode; it relies in a hook 
(icomplete-vertical-minibuffer-setup) and an advice 
(icomplete-vertical-format-completions) which in principle we don't need with a 
very simple modification of icomplete-completions and 
icomplete-minibuffer-setup. If icomplete-completions produces the formated 
output it will be more efficient and clean than adding an advice or do a 

That's exactly what should be done: not include the icomplete-vertical package 
as is, but instead make small modifications of the existing icomplete package 
to incorporate the changes.

There are also some customizable options that for a simple working vertical 
mode we shouldn't need (like icomplete-vertical-separator-alist or a face 
icomplete-vertical-separator) unless we want to add them now.

Again, Ergus is completely right! Those, with the benefit of hindsight, are 
over-engineered and shouldn't be included in Emacs. Heck, they shouldn't even 
be in icomplete-vertical. (I've learned that lesson and although I subsequently 
wrote a few more completion UIs, I didn't include options analogous to those.)

Omar Antol�n Camarena

reply via email to

[Prev in Thread] Current Thread [Next in Thread]