Re: Consistent face for keys in *Help* and `substitute-command-keys'

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Sat, 13 Mar 2021 08:27:05 -0600
> Cc: larsi@gnus.org, juri@linkov.net, emacs-devel@gnu.org
> 
> I was able to avoid any vertical resizing using the advice from Stefan M.
> So I pushed the following change to master:
> 
> modified   lisp/faces.el
> @@ -2816,8 +2816,12 @@ help-argument-name
>    :group 'help)
> 
>  (defface help-key-binding
> -  '((((class color) (min-colors 88) (background light)) :background "grey90")
> -    (((class color) (min-colors 88) (background dark)) :background "grey25")
> +  '((((class color) (min-colors 88) (background light))
> +     :background "grey92" :foreground "DarkBlue"
> +     :box (:line-width (1 . -1) :color "grey80"))
> +    (((class color) (min-colors 88) (background dark))
> +     :background "grey23" :foreground "LightBlue"
> +     :box (:line-width (1 . -1) :color "grey35"))
>      (((class color grayscale) (background light)) :background "grey90")
>      (((class color grayscale) (background dark)) :background "grey25")

Thanks, but such non-trivial stuff should always be accompanied by a
comment to explain why we do that.  I added such a comment in this
case, but please in the future make sure to leave a comment.