Re: [Gnu-arch-users] Re: Patch : precomimt hook

[Ethan Benson]

On Sat, Oct 04, 2003 at 06:54:04PM +1000, Robert Collins wrote:
> On Sat, 2003-10-04 at 18:17, Ethan Benson wrote:
> > well perhaps a pre-invoke verison of the hook could be done still
> > using .arch-params/hook, but doing so would probably break everyones
> > existing hooks since they are not written to expect pre-invoke.
> 
> Huh? Fish slap time. Hooks expect operations, and this is a new
> operation. No breakage involved.

only if you do ugly shit like calling it with precommit, instead of
commit.

> > yuk.
> > 
> > i think its a far better design to just exec .arch-params/pre-hook in
> > the exact same manner as .arch-params/hook, the only difference being
> > pre-hook is invoked before the command returns, instead of after.
> 
> so you propose:
> pre-pre-pre hook,
> pre-pre-hook
> pre-hook
> hook
> post-hook-hook
> post-post-hook-hook

where do you read that?

i propose only one addition.  pre-hook.  period.

-- 
Ethan Benson
http://www.alaska.net/~erbenson/

pgp3044gquYKI.pgp
Description: PGP signature