[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mechanisms for reviews needed

From: Jacob
Subject: Re: mechanisms for reviews needed
Date: Tue, 02 Aug 2005 21:02:15 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040805 Netscape/7.2

Andy Jones wrote:
It seems to me that it's all about what the repository actually +is+.

Jacob would like the repository to contain only tested code, ready for
release - if I understand correctly.

No, you misunderstand. This has not to do with unstable vs. stable
or development vs. production code.

I am simply asking for an (optional) review step to prevent the
repository being poluted with crap code. What this review will
contain (nothing, manual review, style check, unit testing,
function test, ...) must be decided by the organization. Typical
it will vary based on the current phase of the project;
For a system already in beta test I'd be very strict on what to
let in. For a prototype mock-up just started I'd be more lenient.

You may claim none of this belong in a VCS and I agree in principle.
Problem is that the system that should take care of this *outside*
the VCS must be so tightly integrated with the VCS that it would be
simpler just to define it as part of it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]