Re: [PATCHES] Re: Harp Pedals?

[Carl D. Sorensen]

On 8/18/08 4:29 PM, "Reinhold Kainhofer" <address@hidden> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am Montag, 18. August 2008 schrieb Carl D. Sorensen:
>> P.S. Reinhold, I haven't checked the code yet.  Have you put
>> harp-diagram-details as part of the text interface?  I think it should go
>> there, since it is a markup.
>
> No, I haven't. I simply looked at what you did with the fret-diagram-details
> and tried to duplicate it ;-) You add the fret-diagram-interface only to the
> FretBoard (not to TextScript), and the fret-diagram-details appears only in
> that interface, not in the text-interface...

Ah, yes... I remember now that I was not sure exactly how to do that.  I
guess I defined the fret-diagram interface, and the fret-diagram-details as
a grob property, but I didn't have any grobs with that interface until
Han-Wen added the FretBoard grob.

For purposes of completeness, I suspect that we should add the
fret-diagram-interface and the harp-pedal-interface to the TextScript grob
in scm/define-grobs.scm.  That way, when people are in the IR and clicking
on TextScript, they'll see that they can change the fret-diagram-details and
the harp-diagram-details.  Right now, I think that information is missing
from the manual.  You can't see that TextScript objects can have a
fret-diagram-details property set.  You can't see that fret-diagram-details
applies to TextScript objects. (I've stated this twice, because I'm talking
about two different directions -- from the grob to the property and from the
grob to the property).

On the other hand, the full fret-diagram-interface doesn't apply to
TextScript.  Only the fret-diagram-details part applies to TextScript.

Perhaps we should define a new interface --
instrument-specific-markup-interface.  It would contain
fret-diagram-details, harp-pedal-details, clarinet-diagram-details (once the
woodwind diagrams get added, etc.  Then the TextScript could have
instrument-specific-markup-interface added as part of the meta structure.

Han-Wen, you're the expert.  Could you chime in here?  I think this is a
hole in the documentation that I left because of my limited understanding.


Thanks,

Carl