Re: [PATCHES] Re: Harp Pedals?

[Carl D. Sorensen]

On 8/19/08 11:19 AM, "Reinhold Kainhofer" <address@hidden> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am Dienstag, 19. August 2008 schrieb Carl D. Sorensen:
>
> Done. I've now commited all my changes to master:
>
> - -) make-line-stencil markup function
> - -) harp pedals implementation and test cases
> - -) instrument-specific-markup-interface in the grob definitions
> - -) change of markup type (for the docs) for fret-boards and harp diagrams
>
> Cheers,
> Reinhold

Great!

I've been looking at ellipse code.  Once I can get rhythms.itely off my
plate (which is waiting on the beatGrouping patch, one way or the other)
I'll add an ellipse in place of the circle.

One issue -- you've left a FIXME in the function for size lookup, but you
are looking up size from the props, so I think the FIXME should go away.

Thanks,

Carl