[PATCHES] Re: Harp Pedals?

[Reinhold Kainhofer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Montag, 18. August 2008 schrieb Han-Wen Nienhuys:
> On Sun, Aug 17, 2008 at 9:10 PM, Reinhold Kainhofer
>
> <address@hidden> wrote:
> > Attached is a patch for stencil.scm, which adds a make-line-stencil that
> > does exactly that: You call it as
> >    (make-line-stencil linewidth xstart ystart xend yend)
> > and it will create the stencil and correctly set its extent (adding half
> > the line width to all coordinates, too).
> >
> > Okay to apply to master?
>
> make sure that duplicate code with the draw-line markup is eliminated

Done, patch is attached. Okay to apply?


Am Sonntag, 17. August 2008 schrieb Carl D. Sorensen:
> Given the uniqueness of harp pedal diagrams, I think it would make sense
> to define a property harp-pedal-details that would be a place to stash
> all the harp-pedal-specific properties.

Done.
I've added a harp-pedal-details property list, which will be used by 
\harp-diagram. For this, I also had to define a harp-pedal-interface, 
although that interface is not used in any grob (I don't need a 
HarpPedalDiagram grob...). Is this okay or do I need to add/change anything.

Attached is now a patch for master, which adds the functionality directly to 
lilypond, together with proper documentation for the appendix of the NR and 
the IR. I've not written anything for the NR "2.3.3.1 Harp", though.

Okay to apply to master?

Cheers,
Reinhold



- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIqcZaTqjEwhXvPN0RAtNVAJ447zjgFm5+d3KNZfUG9zKc7su+kwCeKIqJ
XiqLbTZS8Dyo1U/KAitEE74=
=71jY
-----END PGP SIGNATURE-----

0001-Add-a-make-line-stencil-function-which-correctly-se.patch
Description: Text Data

0002-Feature-Add-Harp-pedal-diagrams-i.e.-a-harp-pedal.patch
Description: Text Data