lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tablature: proper support for tie/slur- and tie/glissando-constellat


From: Marc Hohl
Subject: Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042)
Date: Wed, 20 Oct 2010 11:12:27 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8

Am 18.09.2010 22:21, schrieb address@hidden:
[...]
I think the only sane method would be to use a scheme engraver, since
you could acknowledge interesting grobs and make typesetting decisions
for the TabNoteHead based on the grobs present at a particular timestep.
Done.

> This doesn't belong in 'details since it's set beyond the user's
> control: it only makes sense as an internal property, so should be
> defined separately
Done (I hope I did it right?)

Looks OK.  Just needs a few minor changes:

-) It's not user serviceable so should go in
`all-internal-grob-properties'.
Done.

-) As a flag which is usually #f, it doesn't need to be set in
define-grobs.scm: you can set the default when reading the property
instead.
Done.

-) It needs adding to an interface to prevent error messages popping up.

Done.

Regards,

Marc

http://codereview.appspot.com/2191042/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]