Re: print transposed guitar chords on piano sheets (issue4626094)

[lemniskata . bernoullego]

Some style nitpicks. I also think i found why it didn't work.


http://codereview.appspot.com/4626094/diff/1/lily/chord-name-engraver.cc
File lily/chord-name-engraver.cc (right):

http://codereview.appspot.com/4626094/diff/1/lily/chord-name-engraver.cc#newcode126
lily/chord-name-engraver.cc:126: {
AFAIK when there is only one statement in if, we don't use braces. So it
should be
if (capo)
  capo_inversion = capo_transpose (p, capo_pitch);

http://codereview.appspot.com/4626094/diff/1/lily/chord-name-engraver.cc#newcode135
lily/chord-name-engraver.cc:135: capo_bass = capo_transpose (p,
capo_pitch);
same as above

http://codereview.appspot.com/4626094/diff/1/lily/chord-name-engraver.cc#newcode143
lily/chord-name-engraver.cc:143: capo_pitches = scm_cons (capo_transpose
(p, capo_pitch), capo_pitches);
same as above

http://codereview.appspot.com/4626094/diff/1/lily/chord-name-engraver.cc#newcode166
lily/chord-name-engraver.cc:166: capo_pitches = scm_sort_list
(capo_pitches, Pitch::less_p_proc);
same as above

http://codereview.appspot.com/4626094/diff/1/lily/chord-name-engraver.cc#newcode174
lily/chord-name-engraver.cc:174: capo_markup = scm_call_4 ( name_proc,
capo_pitches, capo_bass, capo_inversion,
same as above

http://codereview.appspot.com/4626094/diff/1/lily/chord-name-engraver.cc#newcode187
lily/chord-name-engraver.cc:187: } else {
i think this should be

if (!capo)
  chord_name_->set_property ("text", markup);
else
{

http://codereview.appspot.com/4626094/diff/1/lily/chord-name-engraver.cc#newcode191
lily/chord-name-engraver.cc:191: SCM hspace_proc =
ly_lily_module_constant ("hspace_markup");
change line_markup to line-markup and hspace_markup to hspace-markup. I
think it will work then.

http://codereview.appspot.com/4626094/