Re: Make accidental styles available as context mods. (issue 4819064)

[dak]

http://codereview.appspot.com/4819064/diff/1/lily/context-mod-scheme.cc
File lily/context-mod-scheme.cc (right):

http://codereview.appspot.com/4819064/diff/1/lily/context-mod-scheme.cc#newcode45
lily/context-mod-scheme.cc:45: LY_DEFINE (ly_make_context_mod,
"ly:make-context-mod",
Can you map this to #{ \with { ... } #} ?

http://codereview.appspot.com/4819064/diff/1/ly/context-mods-init.ly
File ly/context-mods-init.ly (right):

http://codereview.appspot.com/4819064/diff/1/ly/context-mods-init.ly#newcode25
ly/context-mods-init.ly:25: (ly:make-context-mod
#{ \with { \set extraNatural #(second $style-settings)
           \set autoAccidentals #(third $style-settings)
           \set autoCautionaries #(fourth $style-settings) } #}
No, I have not actually tested it, but with the recent changes to #{ #}
something quite similar to this should actually work.  Is there a reason
you prepend the description in order to strip it again in parser.yy?

http://codereview.appspot.com/4819064/